Attention is currently required from: jolly, laforge, neels, osmith.

View Change

3 comments:

• File include/osmocom/core/soft_uart.h:

  • Patch Set #3, Line 54: OSMO_SUART_STATUS_F_CTS = (1 << 5), /*!< Clear To Send */

    (personally i prefer an enum storing just 0, 1, 2, 3, 4, 5, because it is easy to get from 5 to 1<<5 […]

    Yes, you already commented on this in another patch (already merged). As I said, I don't see a practical situation in which I would need to get the `x` value back from `(1 << x)`. If you have examples, let me know.

  • Patch Set #3, Line 61: OSMO_SUART_FLOW_CTRL_M_NONE,

    (apparently it's good practice to set the first item = 0 explicitly)

    It's the first time I am hearing about such a good practice :P If this was a protocol definition, I would go further and set each item explicitly. In the particular case we're discussing here, I can't see the practical benefits.

  • Patch Set #3, Line 100: gets

    wdym, "gets". […]

    "gets passed" or "gets as an argument" -- I will clarify this.

To view, visit change 35172. To unsubscribe, or for help writing mail filters, visit settings.