Attention is currently required from: fixeria.
Patch set 1:Code-Review +1
5 comments:
Commit Message:
Patch Set #1, Line 17: flag (default auto), so that building the rest of osmocom-bb doesn't
I can't find it right now, but I think the auto configure options were discussed some year back on t […]
Agree with @osmith@sysmocom.de, auto shouldn't be there.
File contrib/jenkins.sh:
Patch Set #1, Line 29: osmo-build-dep.sh osmo-trx "" --disable-doxygen --disable-multi-arfcn --without-proxy
AFAIU since we are adding new configure flag, we should change the jenkins.sh to be matrix jenkins job to test both --without-proxy here and also building with it (btw why is there no configure flag when building osmocom-bb below? it's because you are using =auto?)
File src/host/trxcon/src/trx_if.c:
Patch Set #1, Line 484: const struct trxcon_phyif_burst_ind phybi = {
it may make sense to get rid of this struct and pass bi directly below?
Patch Set #1, Line 504: const struct trxcon_phyif_burst_req *br)
Similarly, maybe pass struct osmo_trxd_burst_req directly here as a param?
Patch Set #1, Line 642: osmo_trx_ep_send_ctrl_msg(trx->ep, 0, &cmd_poweroff);
this won't be transmitted most of the time.
Ideally whatever path currently calls osmo_fsm_terminate() should instead be transitioning to a new cleanup state which would flush + send POWEROFF, then when POWEROFF ACK is received free the whole thing.
To view, visit change 43828. To unsubscribe, or for help writing mail filters, visit settings.