Attention is currently required from: osmith, pespin.

View Change

1 comment:

• Commit Message:

  • Patch Set #1, Line 17: flag (default auto), so that building the rest of osmocom-bb doesn't

    This will enable the feature for some people who happen to have libosmo-trx-dev installed, and not for others, who may then see a strange error somewhere down the road when things don't work.

    Not sure what kind of errors you mean. If a user does not need / care about trxcon, this change is irrelevant to them and they don't have to install any additional dependencies. If a user does need trxcon, then they'll see no binary and will need to inspect the configure / build logs to understand why and what's missing.

    To me "auto" actually looks like an acceptable approach here. And this is not new: in `src/host/layer23/configure.ac` we conditionally enable LUA scripting (`BUILD_LUA`) and GAPK I/O (`BUILD_GAPK`) if the respective dependencies are available, i.e. automatically. Other projects like Wireshark also automatically enable/disable certain features at configure-time depending on available dependencies.

    
    If we go for `no` as the default, then it simply does not make sense to have `trxcon` target in the top-level `Makefile` because it will not build the actual binary. I would rather make it `yes` by default and simply remove `trxcon` from the `nofirmware` recipe. But to me, honestly, this is still a less favorable approach.

To view, visit change 43828. To unsubscribe, or for help writing mail filters, visit settings.