Attention is currently required from: fixeria, daniel.
View Change
1 comment:
File src/input/ipa.c:
Patch Set #5, Line 272: /* Delete timer in case conn_open is called multiple times with different connect_timeout */
This should not happen (called several times), the socket would be leaked too then.
I would even add a if (link->ofd->fd != -1) return -EINVAL; or something like that.
To view, visit change 30616. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iaeb672a4c981e9769443fb0cd6c8e59cb76307bd
Gerrit-Change-Number: 30616
Gerrit-PatchSet: 5
Gerrit-Owner: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Dec 2022 14:51:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment