Attention is currently required from: arehbein, daniel, laforge.

View Change

1 comment:

• File include/osmocom/core/gsmtap_util.h:

  • Patch Set #2, Line 30:

    I think this would allow us to keep `gsmtap_inst_fd()` as `static inline` inside the header, without […]

    No, better move it to a function like you did here. Already compiled code will already have the implementation compiled in its code, but at least for new code we now control the implementation in the lib.

    The point of having gsmtap_inst_fd2() as separate of gsmtap_inst_fd2(), is that we can mark the former as DEPRECATED and force everybody to update to gsmtap_inst_fd2() at some point, meaning we know for sure all users will end up using the non-static-inline version.

    So the change of static inline to a full function can be tracked more easily and more clearly.

To view, visit change 34720. To unsubscribe, or for help writing mail filters, visit settings.