Attention is currently required from: arehbein, pespin.
5 comments:
File src/osmo-bsc/bts.c:
Patch Set #9, Line 1744: unsigned long ny1_recommended = (T3124 + GSM_NY1_REQ_DELTA)/T3105 + 1;
Without the '+ 1', due to integer arithmetic in C, we would be setting ny1 to the largest integer sm […]
the standard idiom for integer division rounding up is:
(foo + (bar - 1)) / bar
this avoids false incrementing when the division result was an exact integer
File src/osmo-bsc/bts.c:
(no need for braces when the body is a single line)
Patch Set #14, Line 1729: const struct gsm_lchan *gl = gsm_bts_get_cbch(bts);
(re earlier question, 'lchan' stands for 'logical channel', a sub-division of a BTS timeslot)
Patch Set #14, Line 1738: unsigned long T3105 = osmo_tdef_get(bts->network->T_defs, 3105, OSMO_TDEF_MS, -1);
in osmocom style we are required to declare all variables at the top of the scope
File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:
Patch Set #16, Line 95: (void)
drop the cast to void?
To view, visit change 30602. To unsubscribe, or for help writing mail filters, visit settings.