Attention is currently required from: pespin, fixeria, dexter.
1 comment:
File include/osmo-bts/pcuif_proto.h:
Patch Set #1, Line 156: PCU_IF_NUM_NSE_TIMERS
Extending the timer at the end of the struct would change the message size and hence would break the […]
So, how exactly do I go about updating the PCU IF now/ how does Osmocom go about these version bumps?
It's also not clear to me right now what change is preferred... pespin's last comment
> I wouldn't really care for now about that, I don't expect the size of this array to change lots of times. I'd leave it as/where it is, update the size now like you did.
sounded like this patch would be alright (?) and I should just add a version bump for osmo-bts, osmo-bsc and osmo-pcu?
Last but not least, since that was also mentioned: Should we add this PCU IF change to the version bump in https://gerrit.osmocom.org/c/osmo-bts/+/31600/1/include/osmo-bts/pcuif_proto.h ?
This concerns two other patches of mine as well:
https://gerrit.osmocom.org/c/osmo-pcu/+/31886
and
https://gerrit.osmocom.org/c/osmo-bsc/+/31880 (which I will probably have to change so as to separate out the PCU_IF change)
To view, visit change 31885. To unsubscribe, or for help writing mail filters, visit settings.