Attention is currently required from: pespin.
View Change
1 comment:
File src/libmsc/msc_a.c:
Patch Set #1, Line 1488: codec_if_known->type != GSM0808_SCT_CSD) {
indentation
what way would you recommend? I intentionally didn't put it on the same level as LOG_TRANS(), so it's clear that this is part of the if condition (not sure if our linter complains about that but IIRC flake8 for python does).
To view, visit change 34173. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I94de84df41bcd050d0e7b4e4fea1c6a6551ef7d3
Gerrit-Change-Number: 34173
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Aug 2023 15:14:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment