Attention is currently required from: pespin, fixeria.
8 comments:
Commit Message:
("step")
Patchset:
in general i wish you wouldn't have a habit of putting comments in the same line as code...
this is a lot and i can't really comment on functional accuracy, but looks sane in general.
+1 when the T_def has a desc and a proper X-nr assigned
File src/rlcmac/rlcmac.c:
Patch Set #16, Line 40: { .T=1, .default_val=1, .unit=OSMO_TDEF_S, .desc="foobar", .val=0 },
is this a regression test? doesn't look like one. so probably:
add a desc, give it an unused T number like -32 currently and add X32 to https://osmocom.org/projects/cellular-infrastructure/wiki/List_of_Timer_numbers
drop .val = 0, it is redundant. (also because tdefs will be initialized to default_val so = 0 may be confusing)
File src/rlcmac/tbf_ul_ass_fsm.c:
Patch Set #16, Line 53: [GPRS_RLCMAC_TBF_UL_ASS_ST_COMPL] = { },
(could just omit unset ones)
File src/rlcmac/tbf_ul_fsm.c:
Patch Set #16, Line 42: [GPRS_RLCMAC_TBF_UL_ST_FLOW] = { },
(same)
drop this func?
(extra blank line)
(trailing blank line)
To view, visit change 31099. To unsubscribe, or for help writing mail filters, visit settings.