Attention is currently required from: neels, fixeria, dexter.
Patch set 17:Code-Review -1
6 comments:
File include/osmocom/pcu/pcuif_proto.h:
Patch Set #17, Line 48: #define PCU_IF_FLAG_DT (1 << 2)/* use TLLI for confirmation directly */
I think we agreed in the call this flag was not needed.
Patch Set #17, Line 280: uint8_t pgroup[3];
This can be a int16_t containing a number 0-999.
Patch Set #17, Line 294: struct gsm_pcu_if_data_cnf_dt data_cnf_dt;
isn't it a bit weird that we have a cnf_dt but no data_dt?
File src/bts.h:
Patch Set #17, Line 282: /* Use the TLLI directly to handle IMMEDIATE ASSIGNMENT confirmation, otherwise the TLLI is extracted
This is most probably not needed anymore and can be dropped.
File src/bts.cpp:
Patch Set #17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf)));
I thought we agreed on dropping the previous message?
File src/pcu_l1_if.cpp:
this can be dropped.
To view, visit change 31145. To unsubscribe, or for help writing mail filters, visit settings.