Attention is currently required from: laforge, neels.

View Change

1 comment:

• File src/osmo-hnbgw/nft_kpi.c:

  • Patch Set #9, Line 994: nft_kpi_get_counters_schedule();

    I agree with neels that his approach implements what we discussed (for the reasons we discussed and […]

    As mentioned, I'm just asking to account for the elapsed time between triggers by writing a few more lines of code, which I already presented as an example. It's 10 min of work, nothing requiring days or weeks of work...
    If it's painful doing it in this same commit, feel free to submit it as a follow-up improvement, but this should be there when merging this feature because it's super easier and will make users not wasting time asking themselves why the timers are triggering out of time.

To view, visit change 36539. To unsubscribe, or for help writing mail filters, visit settings.