Attention is currently required from: laforge, pespin, fixeria.

View Change

1 comment:

• File include/osmocom/pfcp/pfcp_msg.h:

  • Patch Set #3, Line 44: #define OSMO_LOG_PFCP_MSG_SRC(M, LEVEL, file, line, FMT, ARGS...) do { \

    Its also the first time we are reaching this kind of complexit in a log macro...

    in principle LOG_TS(), LOG_LCHAN() and others are doing similar things.
    You can see them with this run across all osmo trees:

     rgrep '#define.LOG_.*do' -A 10

    I don't understand why you guys oppose this being a macro, and I guess I never will.
    But if you insist, I can change it to a va_list function.
    Maybe in a separate patch?

To view, visit change 27631. To unsubscribe, or for help writing mail filters, visit settings.