Attention is currently required from: fixeria, laforge, osmith.
View Change
1 comment:
File src/ss7_asp.c:
Patch Set #3, Line 801:
what kind of syntax is that "(void) rc;" without assigning any value to rc? I don't know what it is […]
This is a "well-known" way to write a "NO-OP" in C which can basically be used to let compiler see the var as used and don't warn about, ie. stating that it's known by programmer that the variable is not used.
I prefer having it this way since it shows the reader that there's a return code, plus allows debugging the return code with the debugger.
To view, visit change 40481. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I2a9338053e741fb6dab94492c6bdc2badaf7afb1
Gerrit-Change-Number: 40481
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Jun 2025 12:04:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>