Attention is currently required from: csaba.sipos, fixeria, laforge.
3 comments:
Patchset:
I'm sorry to keep delaying merge of this, but I ask for simpel changes sometimes and then new version seems to have changed substantially again from last version..
File src/osmo-bsc/bts_nokia_site.c:
Patch Set #9, Line 1857: if (find_element(noh->data, len_data, NOKIA_EI_OBJ_ID, object_identity, sizeof(object_identity)) != sizeof(object_identity) ||
This is now tons of lines >120 chars (the maximum as per osmocom guidelines) and becomes unreadable when looking at diffs.
Also, it's really really hard to follow on this since it's full of several levels of if/else everywhere.
Patch Set #9, Line 1858: find_element(noh->data, len_data, NOKIA_EI_OBJ_STATE, &object_state, sizeof(object_state)) != sizeof(object_state)) {
this is not properly aligned to the line above.
To view, visit change 39416. To unsubscribe, or for help writing mail filters, visit settings.