Attention is currently required from: laforge, lynxis lazus, pespin.
View Change
1 comment:
File src/s1ap_proxy.erl:
Patch Set #6, Line 92: proc(OrigData, S0) ->
this function name is way too generic and I can imagine a total confusion if seeing this appear on e […]
Any naming suggestions? I was having hard time inventing something else than `handle_pdu`. BTW, the reason I had to rename this function is because it's of the same arity as the one in private API now, and Erlang complains about that...
To view, visit change 37924. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4
Gerrit-Change-Number: 37924
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis@fe80.eu>
Gerrit-Comment-Date: Thu, 26 Sep 2024 14:01:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>