fixeria submitted this change.

View Change

Approvals: Jenkins Builder: Verified neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved
library/BSSMAP_Templates: add missing LCS {Priority,QoS} IEs

According to 3GPP TS 48.008, section 3.2.1.71, the LCS QoS IE shall
be present if location of the target MS is requested and is optional
otherwise. Since [1], osmo-bsc started to check presence of this IE,
so let's add it to ts_BSSMAP_Perform_Location_Request.

Taking a chance, let's also add LCS Priority IE.

Change-Id: If2bd6e636d3ee695abab9ed40417dc53ec68fd12
Related: [1] osmo-bsc.git Ifeb359b0468845da0b4fed9e2e4b79256067fa81
Related: SYS#5891
---
M library/BSSMAP_Templates.ttcn
1 file changed, 32 insertions(+), 3 deletions(-)

diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn
index 07c7c8d..376cea6 100644
--- a/library/BSSMAP_Templates.ttcn
+++ b/library/BSSMAP_Templates.ttcn
@@ -1881,10 +1881,39 @@
category := category
}

+template (value) BSSMAP_IE_LCSPriority
+ts_BSSMAP_IE_LCSPriority(template (value) OCT1 priority := '00'O) := {
+ elementIdentifier := '43'O,
+ lengthIndicator := 0, /* overwritten */
+ priority := priority
+}
+
+template (value) BSSMAP_IE_LCSQOS
+ts_BSSMAP_IE_LCSQOS(template (value) BIT1 vCI := '0'B,
+ template (value) BIT1 vEL := '0'B,
+ template (value) BIT1 hAI := '1'B,
+ template (value) BIT7 hAV := '0010010'B,
+ template (value) BIT1 vAI := '0'B,
+ template (value) BIT7 vAV := '0000000'B) := {
+ elementIdentifier := '3E'O,
+ lengthIndicator := 0, /* overwritten */
+ vCI := vCI, /* Vertical Coordinate Indicator: VC requested ('1'B) or not ('0'B) */
+ vEL := vEL, /* report velocity if available (1) or not(0) */
+ spare_1_6 := '000000'B,
+ horizontalAccuracy := hAV, /* Accuracy Horizontal (HA) */
+ hAI := hAI, /* Horizontal Accuracy Indicator HA is specified (1) or not (0) */
+ verticalAccuracy := vAV, /* Accuracy Vertical (VA) */
+ vAI := vAI, /* Vertical Accuracy Indicator VA is specified (1) or not (0) */
+ spare_2_6 := '000000'B,
+ rTC := '00'B /* Response Time is not specified */
+}
+
template (value) PDU_BSSAP
ts_BSSMAP_Perform_Location_Request(template (omit) BSSMAP_IE_IMSI imsi,
template (omit) BSSMAP_IE_CellIdentifier cellIdentifier := omit,
- template (omit) BSSMAP_IE_LCSClientType clientType := ts_BSSMAP_IE_LCSClientType)
+ template (omit) BSSMAP_IE_LCSClientType clientType := ts_BSSMAP_IE_LCSClientType,
+ template (omit) BSSMAP_IE_LCSPriority priority := ts_BSSMAP_IE_LCSPriority,
+ template (omit) BSSMAP_IE_LCSQOS qos := ts_BSSMAP_IE_LCSQOS)
modifies ts_BSSAP_BSSMAP := {
pdu := {
bssmap := {
@@ -1895,8 +1924,8 @@
classmarkInformationType3 := omit,
lCS_ClientType := clientType,
chosenChannel := omit,
- lCS_Priority := omit,
- lCS_QOS := omit,
+ lCS_Priority := priority,
+ lCS_QOS := qos,
gPS_AssistanceData := omit,
aPDU := omit,
iMSI := imsi,

To view, visit change 27567. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If2bd6e636d3ee695abab9ed40417dc53ec68fd12
Gerrit-Change-Number: 27567
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged