Attention is currently required from: dexter, laforge, neels.
Patch set 4:Code-Review +1
3 comments:
Patchset:
I don't see any good reason not to use container_of here instead of casting.
File src/codec/ecu_fr.c:
Patch Set #4, Line 92: struct osmo_ecu_state ecu_state;
Add a comment that ecu_state should be the first in the struct.
If you used container_of, this wouldn't be required.
Patch Set #4, Line 294: return (struct osmo_ecu_state*) fr;
while the cast is fine, the container_of would probably be safer and would allow this struct to be anywhere, with no real cost (a few arithmetic operations).
To view, visit change 35212. To unsubscribe, or for help writing mail filters, visit settings.