laforge submitted this change.

View Change

Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
sccp_scmg: ignore PCSTATE.indication

Silence the error log for PCSTATE.indication prims.

When running the HNBGW_Tests.ttcn suite, the osmo-hnbgw LOGL_ERROR is
spammed with messages like:

DLSCCP ERROR unsupported SCCP user primitive N-PCSTATE.indication (sccp_scmg.c:298)

Add this prim to scmg_prim_cb() to just log on DEBUG that it is ignored.

Related: OS#5679
Change-Id: I5fd38afea94f48ed2f2fcd2d9baa8ec22a571b6b
---
M src/sccp_scmg.c
1 file changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/sccp_scmg.c b/src/sccp_scmg.c
index ef3a0b3..a8ac766 100644
--- a/src/sccp_scmg.c
+++ b/src/sccp_scmg.c
@@ -294,6 +294,9 @@
scmg->affected_pc = osmo_load16le(&scmg->affected_pc);
rc = scmg_rx(scu, &param->calling_addr, &param->called_addr, scmg);
break;
+ case OSMO_PRIM(OSMO_SCU_PRIM_N_PCSTATE, PRIM_OP_INDICATION):
+ LOGP(DLSCCP, LOGL_DEBUG, "Ignoring SCCP user primitive %s\n", osmo_scu_prim_name(oph));
+ break;
default:
LOGP(DLSCCP, LOGL_ERROR, "unsupported SCCP user primitive %s\n",
osmo_scu_prim_name(oph));

To view, visit change 31363. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I5fd38afea94f48ed2f2fcd2d9baa8ec22a571b6b
Gerrit-Change-Number: 31363
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-MessageType: merged