Attention is currently required from: laforge, pespin.

View Change

2 comments:

• File src/core/osmo_io.c:

  • Patch Set #5, Line 338: pending = iofd_msgb_alloc2(iofd, msgb_length(iofd->pending) + msgb_length(msg));

    AFAICT this is not fullfilling the requirement that: […]

    The code path of iofd_msgb_alloc2 is called, if the msg would not fit into the tailroom of iofd->pending. This implies that the length of data in iofd->pending plus the lengh of data in msg exceed the iofd->msgb_alloc.size. The allocated message will have a size that is greater.

• File src/core/osmo_io_internal.h:

  • Patch Set #5, Line 156: struct msgb *iofd_msgb_alloc2(struct osmo_io_fd *iofd, size_t extra);

    this pnew param is named "size" now in the .c file.

    Done

To view, visit change 40584. To unsubscribe, or for help writing mail filters, visit settings.