pespin has uploaded this change for review.

View Change

Improve docuemntation of enum osmo_ss7_as_traffic_mode

Change-Id: Icc4dcbe37208a64b73a07d4432d353edf03af978
---
M include/osmocom/sigtran/osmo_ss7.h
M include/osmocom/sigtran/protocol/m3ua.h
2 files changed, 12 insertions(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/58/39658/1

diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h
index d35b870..51c1cbd 100644
--- a/include/osmocom/sigtran/osmo_ss7.h
+++ b/include/osmocom/sigtran/osmo_ss7.h
@@ -172,10 +172,20 @@
  * SS7 AS Traffic Mode
  ***********************************************************************/
 
+ /* Traffic mode implementations which can be configured on an AS, either by
+  * peer (eg. RFC4666 M3UA "Traffic Mode Type") or locally through VTY.
+  * Note: This is related but not exactly RFC4666 M3UA "Traffic Mode Type" (enum
+  * m3ua_traffic_mode). */
 enum osmo_ss7_as_traffic_mode {
-	OSMO_SS7_AS_TMOD_OVERRIDE = 0,	/* default */
+	/* RFC4666 M3UA "Traffic Mode Type" "Override". Default traffic mode: */
+	OSMO_SS7_AS_TMOD_OVERRIDE = 0,
+	/* RFC4666 M3UA "Traffic Mode Type" "Broadcast": */
 	OSMO_SS7_AS_TMOD_BCAST,
+	/* RFC4666 M3UA "Traffic Mode Type" "Loadshare",
+	 * traffic distribution based on OPC+SLS: */
 	OSMO_SS7_AS_TMOD_LOADSHARE,
+	/* RFC4666 M3UA "Traffic Mode Type" "Loadshare",
+	 * traffic distribution implemented as round-robin: */
 	OSMO_SS7_AS_TMOD_ROUNDROBIN,
 	_NUM_OSMO_SS7_ASP_TMOD
 };
diff --git a/include/osmocom/sigtran/protocol/m3ua.h b/include/osmocom/sigtran/protocol/m3ua.h
index ecbe37b..0f237d4 100644
--- a/include/osmocom/sigtran/protocol/m3ua.h
+++ b/include/osmocom/sigtran/protocol/m3ua.h
@@ -172,6 +172,7 @@
 	M3UA_ERR_NO_CONFGD_AS_FOR_ASP	= 0x1a,
 };
 
+/* Traffic Mode Type */
 enum m3ua_traffic_mode {
 	M3UA_TMOD_OVERRIDE	= 1,
 	M3UA_TMOD_LOADSHARE	= 2,

To view, visit change 39658. To unsubscribe, or for help writing mail filters, visit settings.