Attention is currently required from: neels, laforge, fixeria, msuraev.

Patch set 11:Code-Review -1

View Change

1 comment:

• Patchset:

  • Patch Set #11:

    I'm still not following why do we need this function. This function gets 1 struct osmo_sockaddr as input, so it cannot really handle multiaddress, because osmo_sockaddr holds only address.
    Hence, if you simply want to get the string representation of 1 IP address, you already have:
     const char *osmo_sockaddr_ntop(const struct sockaddr *sa, char *dst);

    In case you want to print the port too, the osmo_sockaddr_to-str_buf2 already makes the job.
    Am I missing something?

To view, visit change 28995. To unsubscribe, or for help writing mail filters, visit settings.