Attention is currently required from: dexter.
View Change
2 comments:
Commit Message:
Patch Set #4, Line 14: moment is no way to do that, so lets add a line_create callback that,
"moment there is no way" sounds better
File src/e1_input.c:
Patch Set #4, Line 646: return NULL;
That looks pretty important - shouldn't we log smth to let lib user know why the line wasn't created?
To view, visit change 32400. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I404fa23e9b8a952be84e9716889c0dbbbc665d22
Gerrit-Change-Number: 32400
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: msuraev <msuraev@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Apr 2023 12:21:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment