Attention is currently required from: daniel, laforge, pespin.

View Change

2 comments:

• File include/osmocom/core/gsmtap_util.h:

  • Patch Set #2, Line 30:

    in summary: gsmtap_inst_fd() will now become a monster, so better make sure nobody uses that cursed […]

    Alright... so I have deprecated `gsmtap_inst_fd()` and added `gsmtap_inst_fd2()` without yet changing anything about the implementation (that would be the next commit, I suppose).

• File src/core/libosmocore.map:

  • Patch Set #2, Line 42: gsmtap_inst_fd;

    Yes, but let's add it as gsmtap_inst_fd2 better.

    I have added `gsmtap_inst_fd` and `gsmtap_inst_fd2` (the latter as deprecated) to libosmocore.map .

    I have only added a TODO-RELEASE line for `gsmtap_inst_fd2`. Should I add the deprecated function there, as well?

To view, visit change 34720. To unsubscribe, or for help writing mail filters, visit settings.