Attention is currently required from: pespin.

View Change

1 comment:

• File src/osmo-bsc/abis_om2000.c:

  • Patch Set #1, Line 2777: uint8_t *cur = o2h->data+3;

    You are accessing msg already here before the first check you added in 2785, are you sure this is co […]

    o2h points to l2 pointer of msg.
    o2h->data points behind the o2h header.
    o2h->data+3 points 3 bytes after the o2h header.
    I am not accessing anything, just setting a pointer (cur) with an offset ahead of the l2 pointer of msg. This should not be a problem. Please correct me, if I am wrong.

To view, visit change 43293. To unsubscribe, or for help writing mail filters, visit settings.