Attention is currently required from: neels, laforge.
View Change
1 comment:
Patchset:
Patch Set #7:
while I generally would agree with pau that we shouldn't re-run code generating the result every tim […]
Ok, if others are fine with it let's merge it, though I really think this paradigm of having to call a function before every use of a struct is not nice at all.
Furthermore, that probably logs stuff at a point in time way after the change in input params was probably made.
To view, visit change 31698. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie0668c0e079ec69da1532b52d00621efe114fc2c
Gerrit-Change-Number: 31698
Gerrit-PatchSet: 7
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Wed, 15 Mar 2023 08:04:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Gerrit-MessageType: comment