Attention is currently required from: jolly, laforge, pespin.

3 comments:

Patchset:
- Patch Set #2:
  The idea was to wait 3 seconds, which allows the MS to receive the SI5* messages before adding the S […]
  I don't have a strong preference here... What happens if an MS gets `SI10` before `SI5`? I would expect the phone to ignore `SI10` in this case? Or cache it and postpone handling until `SI5` is received (this is what we do in osmocom-bb.git for `SI3`/`SI4` and `SI1`).
  Even if `SI10` is ignored when received before `SI5`, the BTS will be broadcasting it repeatedly on SACCH anyway. Based on that, I think we can send it for every channel that is established straightaway, without delaying.
File src/osmo-bsc/system_information.c:
- Patch Set #2, Line 1428:
```
unsigned int save_cur_bit;
	struct gsm_subscriber_connection *c;
```
  I always want to separate variables from code. […]
  You could still have them variables defined separately from code within a for-loop, but it's not really critical and I am not going to block. Marking as resolved.
- Patch Set #2, Line 1447: 32
  SI 10 uses channel index with 5 bit. […]
  Makes sense. Marking as resolved.

To view, visit change 34626. To unsubscribe, or for help writing mail filters, visit settings.