Attention is currently required from: fixeria.
1 comment:
Commit Message:
So this allows an application to remove the odd 'D' from category names,
without any changes in any VTY configuration.
IIUC, the [only?] benefit of using this new API is that you can define a `struct log_info_cat` array […]
(FYI, this is not sysmocom work, but a private itch)
The way this character stripping is done in the VTY code introduces an inconsistency.
The correct and consistent way would be for the VTY to use exactly the category name that is defined and also output in log output, i.e. including the leading D if the application has one. That way it is up to the application what names it chooses, and the names are the same everywhere.
Since I cannot change this VTY behavior now (all osmo applications depend on that), i at least hope to offer a new application a consistent experience with category names on the VTY. An optional switch to change to consistent behavior.
My motivation:
I always found this leading D annoying, as apparently did the logging_vty.c implementer, unfortunately. I find it even more madly insane that, for example, DLMGCP now becomes "lmgcp" -- why strip the D and not the L? the whole thing about the D is very inelegant -- why print an extra meaningless character on each and every log line? But ok, say we want an extra "D" everywhere; then why not on the VTY???
I'm hacking on "osmo-gsm-shark" in my private time, and wanted to get rid of those Ds there.
To view, visit change 36546. To unsubscribe, or for help writing mail filters, visit settings.