Attention is currently required from: fixeria.
Patch set 5:Code-Review +1
4 comments:
Patchset:
As far as I can see this patch is almost ready for merging. Since we do not need to set the alpha id here anymore I would recommend to re-align the patch a bit. Otherwise everything should be fine.
I think this might possibly no longer be needed with https://gerrit.osmocom. […]
One still has to ensure to pass the file length (total_len=f_smsp.rec_len) to encode_record_hex. So this patch is still relevant.
File pySim/esim/saip/personalization.py:
Patch Set #5, Line 637: ef_smsp_dec['alpha_id'] = ''
With (I0ec99b2648b22c56f9145345e4cd8776f9217701, already merged), setting the alpha id is optional. You could remove this line and it would still work.
Patch Set #5, Line 638: f_smsp.rec_len = 42
Keep in mind that this hardcoded value (42) must be consistent with the file length assigned in the PE. But as far as I remember we already discussed that and found that the generator would ensure the consistency. I just wanted to remind you to be sure.
To view, visit change 42674. To unsubscribe, or for help writing mail filters, visit settings.