Attention is currently required from: jolly.

View Change

5 comments:

• Commit Message:

  • Patch Set #3, Line 17: This change ensures that newly received data is appended to the existing

    First you say we don't want to reuse the pending buffer, but here you say "This change ensures that newly received data is appended to the existing pending buffer", which seems to be the opposite of what you first stated?

• File src/core/osmo_io.c:

  • Patch Set #3, Line 177: /*! convenience wrapper to call msgb_alloc with parameters from osmo_io_fd (with extra size) */

    "with extra size" here doesn't apply anymore?

  • Patch Set #3, Line 178: struct msgb *iofd_msgb_alloc2(struct osmo_io_fd *iofd, size_t size)

    This is probably breaking the promise that msgb passed to the app are at least of a certain size configured by the user.

  • Patch Set #3, Line 335: * If the pending message is not large enough, create a larger message. */

    I may be wrong, but I'd expect user to configure iofd with a max_size big enough to allow whatever size is needed?

  • Patch Set #3, Line 344: memcpy(msgb_put(iofd->pending, msgb_length(msg)), msgb_data(msg), msgb_length(msg));

    Can we avoid 2 memcpys (here and above) in the specific code path?

To view, visit change 40584. To unsubscribe, or for help writing mail filters, visit settings.