Attention is currently required from: laforge, fixeria, msuraev.

Patch set 58:Code-Review -1

View Change

1 comment:

• File src/libsmpputil/smpp_smsc.c:

  • Patch Set #49, Line 985: osmo_stream_srv_link_close(smsc->link);

    Indeed, would be nice to dig deeper to understand why changing refcounting breaks tests. […]

    I disagree. You are completely refactoring that code, destructions paths, etc.
    And during this move it appears that setting a freed pointer to NULL make test fail, which indicates something is wrong.
    So be it in a follow-up patch or in the same patch, this should be investigated and fixed before merging this patch, in order to avoid potential regressions.

To view, visit change 28849. To unsubscribe, or for help writing mail filters, visit settings.