osmith has uploaded this change for review.

View Change

jenkins-gerrit/comment_generate: fail on 0 passed

Don't print the success message when zero jobs has passed. If this
happens, we have an internal error somewhere.

Change-Id: I1317f14c2f3f55f2a9b6581372c80edba33528db
---
M scripts/jenkins-gerrit/comment_generate.py
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/98/43198/1

diff --git a/scripts/jenkins-gerrit/comment_generate.py b/scripts/jenkins-gerrit/comment_generate.py
index fc8a8b1..1b3bfcd 100755
--- a/scripts/jenkins-gerrit/comment_generate.py
+++ b/scripts/jenkins-gerrit/comment_generate.py
@@ -212,6 +212,8 @@
 
     summary += f"{len(jobs['passed'])} passed:\n"
     summary += get_jobs_list_str(jobs["passed"])
+    if not jobs['passed']:
+        summary += "Zero jobs passed, internal script error?\n"
 
     if "build" in pipeline and "deb" in pipeline and "rpm" in pipeline and \
             not pipeline["build"]["passed"] and pipeline["deb"]["passed"] \
@@ -227,7 +229,7 @@
         summary += "https://osmocom.org/projects/cellular-infrastructure/wiki/Linting\n"
 
     summary += "\n"
-    if jobs["failed"]:
+    if jobs["failed"] or not jobs['passed']:
         summary += "Build Failed\n"
         summary += "\n"
         summary += f"Find the Retrigger button here:\n{build_url}\n"

To view, visit change 43198. To unsubscribe, or for help writing mail filters, visit settings.