Attention is currently required from: osmith, Hoernchen, neels, laforge, pespin, fixeria.
4 comments:
Patchset:
Sorry for the back and forth changes, I tried to merge your changes and still keep the lost changes from https://gerrit.osmocom.org/c/libosmocore/+/30934/8..9 and I had some trouble seeing what was intentional and what was merely code from a previous version.
File src/core/osmo_io.c:
Patch Set #8, Line 206: iofd->tx_queue.current_length--;
Could be msgb_dequeue_count(), but can stay this way too.
See discusion in iofd_txqueue_enqueue()
File src/core/osmo_io.c:
Patch Set #13, Line 82: fprintf(stderr, "Invalid osmo_io backend requested: \"%s\nCheck the environment variable %s\n", backend, OSMO_IO_BACKEND_ENV);
You are missing a \" before first \n.
Thanks, fixed
File src/core/osmo_io_poll.c:
Patch Set #13, Line 93: if (rc < 0) {
I think I changed this and you are changing it again. […]
I though I had msg == NULL for a reason, but this is the sending side...
Thinking about it some more we definitely want to report a send rc of 0 to the user since that can indicate a broken connection. If we re-enqueue in that case we'll busy loop trying to send and send returning 0.
Keeping the msg does make sense so I'll change it to reenqueue only if (rc > 0 && rc < msgb_length(msg))
To view, visit change 30934. To unsubscribe, or for help writing mail filters, visit settings.