Attention is currently required from: pespin.

View Change

1 comment:

• File src/trau/trau_rtp_conv.c:

  • Patch Set #1, Line 671: if (data[0] & 0xD0)

    well, the purpose precisely is that I don't have to look at the exact structure of that byte each ti […]

    The check in question needs to be performed in two functions, HR to TRAU-16k-DL and HR to TRAU-8k-DL. We could factor out a helper function for RFC 5993 validation that would act in the most straightforward manner: first check the F bit, then extract FT and validate it. But a one-line check of `(data[0] & 0xD0)` is way more efficient that calling (or even inlining) a helper function that does two separate bit-field checks.

    In the new patch revision, I added a detailed comment explaining all of this logic. Can we please accept this version?

To view, visit change 39626. To unsubscribe, or for help writing mail filters, visit settings.