Attention is currently required from: pespin.

View Change

6 comments:

• File src/nacc_fsm.c:

  • Patch Set #2, Line 273: /* Classify the RAT type of the cell that is proposed in the PacketCellChangeNotification. In case the RAT is GERAN,

    Can you maybe convert these defines to an enum and provide spec reference on where to find this exac […]

    (I came up with this, those values are just return codes. The spec encodes the RAT type in this weird tree structure.)

  • Patch Set #2, Line 278: static int fill_neigh_key_from_bts_pkt_cell_chg_not(struct nacc_fsm_ctx *ctx,

    I actually think you don't need to return 0/1/2 here, see below.

    Done

  • Patch Set #2, Line 344: return NACC_EUTRAN_CELL;

    maybe set ctx->neigh_key_valid = false explicitly for readers to understand better (and to make sure […]

    Done

  • Patch Set #2, Line 398: } else if (rc == NACC_UTRAN_CELL || rc == NACC_EUTRAN_CELL) {

    I think in here what you may actually want to do is: […]

    I think this makes sense. This also simplifies fill_neigh_key_from_bts_pkt_cell_chg_not() and we can check ctx->neigh_key_valid (now renamed to ctx->neigh_key_present). No neigh_key_present + return code 0 => no system information provided.

  • Patch Set #2, Line 433: else if (rc == NACC_UTRAN_CELL || rc == NACC_EUTRAN_CELL) {

    see same as above.

    Done

• File src/neigh_cache.h:

  • Patch Set #2, Line 68: /* TODO: This function seems to be used only in neigh_cache.c, make it static? */

    this is definetly another patch. Fine with making it static.

    Done

To view, visit change 33538. To unsubscribe, or for help writing mail filters, visit settings.