dexter submitted this change.

View Change


Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved falconia: Looks good to me, but someone else must approve
fix E1 TS output when used with osmo-e1d

The original code did E1 raw TS output by posting directly to
&ts->raw.tx_queue instead of calling e1inp_ts_send_raw();
doing so bypasses the call to driver->want_write performed in
e1inp layer. This approach worked for DAHDI where no
select-for-write is used; however, e1inp interface to osmo-e1d
does use select-for-write, hence applications like osmo-mgw
do need to use e1inp_ts_send_raw() API in order to work
correctly.

Change-Id: Ia2e0fa27195fc1ae75e441038eb4adeb4cf1d6cf
---
M src/ericsson-rbs/er_ccu_if.c
1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/src/ericsson-rbs/er_ccu_if.c b/src/ericsson-rbs/er_ccu_if.c
index 98abbf7..ad7f353 100644
--- a/src/ericsson-rbs/er_ccu_if.c
+++ b/src/ericsson-rbs/er_ccu_if.c
@@ -126,7 +126,7 @@
DEBUG_BYTES_MAX ? DEBUG_BYTES_MAX : msgb_length(msg)));

/* Hand data over to the E1 stack */
- msgb_enqueue(&ts->raw.tx_queue, msg);
+ e1inp_ts_send_raw(ts, msg);
}

/* Callback function to handle incoming E1 traffic */

To view, visit change 37550. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia2e0fa27195fc1ae75e441038eb4adeb4cf1d6cf
Gerrit-Change-Number: 37550
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: falconia <falcon@freecalypso.org>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged