Attention is currently required from: iedemam, neels.

View Change

5 comments:

• File src/osmo-bsc/bts_trx_vty.c:

  • Patch Set #4, Line 575: vty_out(vty, " Activated %llu ms ago%s", duration_ms, VTY_NEWLINE);

    Probably more interesting to print it in VTY as seconds? Doesn't look like we can glance millisecond updates in the VTY anyway.

• File src/osmo-bsc/bts_vty.c:

  • Patch Set #4, Line 3830: vty_out(vty, " Channel Activations : %"PRIu64" TCH", activations_tch);

    I'd rather put it:
      Channel Activations:
          TCH   (avg lifespan 3s)
          SDCCH (avg lifespan 5s)

    See the line formatting, and also use seconds instead of milliseconds. "Average" can probably be shortened to "avg".

• File src/osmo-bsc/lchan_fsm.c:

  • Patch Set #4, Line 1812: long long duration_ms = gsm_lchan_active_duration_ms(lchan);

    Shouldn't this be an unsigned long long everywhere? Maybe simply use time_t?

  • Patch Set #4, Line 1814: if (lchan->type == GSM_LCHAN_TCH_F || lchan->type == GSM_LCHAN_TCH_H) {

    I'd go for a switch statement here, but not critical.

  • Patch Set #4, Line 1816: rate_ctr_add(rate_ctr_group_get_ctr(bts_ctrs, BTS_CTR_LCHAN_TCH_TOTAL_ACTIVE_MILLISECONDS), duration_ms);

    Does it really makes sense to use this kind of value as a rate_ctr? Just asking. It's difficult to interpet it I think.

To view, visit change 27081. To unsubscribe, or for help writing mail filters, visit settings.