Attention is currently required from: arehbein.
View Change
1 comment:
File src/stream.c:
Patch Set #5, Line 1947: /* msgb_l1(msg) is expected to be set */
I dont really get this part. Why do we expect a caller to have msgb_l1() set? And why do we care about it? Why would the user push an ipa header to th message before tranasmit, and then this code pushing the heasers (again)?
To view, visit change 33201. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529
Gerrit-Change-Number: 33201
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein <arehbein@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: arehbein <arehbein@sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Jun 2023 14:53:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment