laforge submitted this change.

View Change


Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve
Cosmetic: gsm48_cc_tx_setup: tweak comment

Remove the misleading "We must not pass bearer_cap to
codec_filter_init()" part of the comment. The function doesn't accept a
bearer_cap parameter, it cannot be passed to the function:

void codec_filter_init(struct codec_filter *codec_filter)
{
*codec_filter = (struct codec_filter){};
}

Related: OS#4394
Change-Id: I87a1e371e108d8da514b30f1726aad0f85ea4111
---
M src/libmsc/gsm_04_08_cc.c
1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c
index 9d429a0..9670db0 100644
--- a/src/libmsc/gsm_04_08_cc.c
+++ b/src/libmsc/gsm_04_08_cc.c
@@ -802,9 +802,8 @@
/* MT call leg is starting. Gather all codecs information so far known.
* (Usually) paging has succeeded, and now we're processing the MNCC Setup from the remote MO call leg.
* Initialize the codecs filter with this side's BSS' codec list, received at Complete Layer 3.
- * We must not pass bearer_cap to codec_filter_init(), because we haven't received the MT MS's Bearer
- * Capabilities yet; the Bearer Capabilities handled here are actually the remote call leg's Bearer
- * Capabilities. */
+ * We haven't received the MT MS's Bearer Capabilities yet; the Bearer Capabilities handled here are
+ * actually the remote call leg's Bearer Capabilities. */
codec_filter_init(&trans->cc.codecs);
codec_filter_set_ran(&trans->cc.codecs, trans->msc_a->c.ran->type);
codec_filter_set_bss(&trans->cc.codecs, &trans->msc_a->cc.compl_l3_codec_list_bss_supported);

To view, visit change 33359. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I87a1e371e108d8da514b30f1726aad0f85ea4111
Gerrit-Change-Number: 33359
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged