Attention is currently required from: fixeria, pespin.

View Change

5 comments:

• File ipad/IPAd_Tests.ttcn:

  • Patch Set #1, Line 51: function f_make_http_resp

    this looks more like a `template`?

    Done

  • Patch Set #1, Line 104: modulepar

    not critical, but we usually have module params on top

    Done

  • Patch Set #1, Line 208: while(true)

    cosmetic: while is not a function (same below)

    Done

  • Patch Set #1, Line 445: for (i := 0; i < sizeof(esipa_res.getBoundProfilePackageResponseEsipa.getBoundProfilePackageOkEsipa.boundProfilePackage.firstSequenceOf87); i := i + 1) {

    sounds like you want to put this in a variable ;) "esipa_res.getBoundProfilePackageResponseEsipa. […]

    I do not know if this looks much nicer ;-/

    var RSPDefinitions.BoundProfilePackage.firstSequenceOf87 firstSequenceOf87 := esipa_res.getBoundProfilePackageResponseEsipa.getBoundProfilePackageOkEsipa.boundProfilePackage.firstSequenceOf87;

  • Patch Set #1, Line 652: // execute ( TC_add_init_eim() );

    why is this one commented out?

    This test requires the IPAd to be called with different command line parameters and a file that contains the eIM configuration. I have used this testcase mainly as a vehicle to see what is spoken to the eUICC on the other end. The testcase does not add much value anyway, so I have removed it now.

To view, visit change 36229. To unsubscribe, or for help writing mail filters, visit settings.