Attention is currently required from: laforge, pespin.
6 comments:
Commit Message:
Patch Set #4, Line 9: Upcoming patches will add handling of arbitrary ftmp strings to
fmtp strings
lol! thx
Patch Set #4, Line 13: Add generic API for handling ftmp strings. The primary intended user is
fmtp
Done
Patchset:
minor nitpick: the subject states "ftmp.h" while in reality it's more than a header.
ah yes, it already secretly morphed from just-a-header to a fmtp.c.
Now it wants to morph into a libosmo-sdp.so.
File src/libosmo-mgcp-client/fmtp.c:
Patch Set #4, Line 29: for (; fmtp && *fmtp && *fmtp != ';'; fmtp++);
fmtp being nonull should be checked only once at start.
Done
Patch Set #4, Line 41: * if (osmo_sdp_fmtp_get_val(res, sizeof(res), fmtp_vals, "mode-set"))
IIUC res contains "0,2,4,7" here, maybe worth saying that.
Done
Patch Set #4, Line 89: int osmo_sdp_fmtp_get_int(const char *fmtp, const char *option_name, int default_value)
did you check in SDP spec if int range is enough?
the fmtp contents are codec specific and not defined in SDP, apart from their general structure (which characters to use for separation). For our known fmtp use cases, we will use numbers as high as 7.
If a fmtp needs a number above two billion, then the caller should use osmo_sdp_fmtp_get_val() to retrieve the value as string. This convenience function is useful only for very very small integers, i.e. below ... TWO BILLION =) scnr
But it took me longer to type this response than it would take to increase the range, so i'm also increasing the range now.
To view, visit change 35434. To unsubscribe, or for help writing mail filters, visit settings.