laforge has uploaded this change for review.

View Change

pySim/ota: Don't modify input argument in OtaDialectSms.encode_cmd

Change-Id: I4c4c44002762696b931ed3580ffe54daf62ffa61
---
M pySim/ota.py
1 file changed, 10 insertions(+), 0 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/39/37139/1

diff --git a/pySim/ota.py b/pySim/ota.py
index 10de611..54e8f75 100644
--- a/pySim/ota.py
+++ b/pySim/ota.py
@@ -332,6 +332,7 @@
             len_cipher = 6 + len_sig + len(apdu)
             padding = otak.crypt._get_padding(len_cipher, otak.crypt.blocksize)
             pad_cnt = len(padding)
+            apdu = bytes(apdu) # make a copy so we don't modify the input data
             apdu += padding
 
         kic = {'key': otak.kic_idx, 'algo': otak.algo_crypt}

To view, visit change 37139. To unsubscribe, or for help writing mail filters, visit settings.