Attention is currently required from: msuraev.

View Change

2 comments:

• File src/host/layer23/src/misc/app_cell_log.c:

  • Patch Set #3, Line 53: fprintf(stderr, "Failed during layer2_open()\n");

    It's better to print layer2_socket_path so user know what exactly failed to open. […]

    Ack

• File src/host/layer23/src/modem/app_modem.c:

  • Patch Set #3, Line 476: rc = layer2_open(app_data.ms, app_data.ms->settings.layer2_socket_path);

    This code is duplicated so many times that I can't help but wonder - why not make shared error-print […]

    I see no need for it, it's a usuall function call + check + print + err.
    Moreover, some apps may use LOGP in there (some amms support osmo logging and some don't iirc).

To view, visit change 30979. To unsubscribe, or for help writing mail filters, visit settings.