Attention is currently required from: arehbein, laforge.
1 comment:
Commit Message:
Not sure why, but select() keeps reporting read events it seems,
even though the client doesn't send any packets anymore.
Looks like the code was originally designed with the idea to set the connection flag `OSMO_STREAM_SR […]
It is possible to close a connection halfway using the shutdown() syscall (see man 2 shutdown). This also means the other end can also do the same, which is notified through TCP FIN.
I'm right now not sure how that reflects on the socket interface though. if you receive a FIN from the peer indicating it finished transmitting, does it announce it somehow on the socket API? I guess in poll based system (like iofd) you simple get no READ notifications from the socket once the Rx queue is empty, so that means you never call read() on it (if you did, it would probably return 0?).
To close the tx side, we'd need oursleves to call shutdown() on the socket FD, which we are not doing anywhere afaict so far.
To view, visit change 33196. To unsubscribe, or for help writing mail filters, visit settings.