Attention is currently required from: daniel.

View Change

1 comment:

• File src/libosmo-mgcp/mgcp_protocol.c:

  • Patch Set #4, Line 1122: remote_osmux_cid = mgcp_osmux_setup(endp, line);

    `handle_create_con()` contains the following code: […]

    It is not needed and it was actually a bug due to messy code before this.

    See how osmux_init_conn() is only called during handle_create_conn(), which means a conn can only be setup as osmux during CRCX.
    In turn, that means, during MDCX, that if a connection was already osmux it means the trunk would already have been configured through mgcp_trunk_osmux_init_if_needed()/mgcp_osmux_setup().

    In MDCX, mgcp_osmux_setup() was only really being called to obtain the osmux CID in case the conn was already specified as being Osmux during previous CRCX.

To view, visit change 39239. To unsubscribe, or for help writing mail filters, visit settings.