Attention is currently required from: osmith.

View Change

3 comments:

• File src/osmo_ss7.c:

  • Patch Set #3, Line 1529: is

    was (this is important for understanding this IMHO, another address was made primary before and here […]

    Ack

  • Patch Set #3, Line 1529: anoter

    another

    Ack

  • Patch Set #3, Line 1558: }

    IMHO this is hard to read, might be worth refactoring to: […]

    • "return early if notif->sn_paddr_change.spc_state is not relevant": that's not really helpful here, it would only make code larger since you'd be basically doing the same comparison twice (early return, then switch).
    • "figure ev_addr and compare it with primary configured in VTY": I can try to factor out a sockaddr_match() specific to this function (simply using regular osmo_sockaddr_cmp() is not enough as can be seen in current code).

To view, visit change 34112. To unsubscribe, or for help writing mail filters, visit settings.