Attention is currently required from: falconia, pespin.

Patch set 2:Code-Review +2

View Change

3 comments:

• File src/codec/gsm660.c:

  • Patch Set #1, Line 271: static con

    @laforge: I checked the code produced by gcc (5.3.0, came with Slackware 14. […]

    Done

  • Patch Set #1, Line 272:

    /* bit numbers relative to "pure" EFR frame beginning,
    			 * not counting the signature bits. */
    			   45,  46,  48,  49,  50,  51,  52,  53,  54,  55,
    			   56,  57,  58,  59,  60,  61,  62,  63,  64,  65,
    			   66,  67,  68,  94,  95,  96,  98,  99, 100, 101,
    			  102, 103, 104, 105, 106, 107, 108, 109, 110, 111,
    			  112, 113, 114, 115, 116, 117, 118, 148, 149, 150,
    			  151, 152, 153, 154, 155, 156, 157, 158, 159, 160,
    			  161, 162, 163, 164, 165, 166, 167, 168, 169, 170,
    			  171, 196, 197, 198, 199, 200, 201, 202, 203, 204,
    			  205, 206, 207, 208, 209, 212, 213, 214, 215, 216,
    			  217, 218, 219, 220, 221 };
    

    I was going for the same code structure and style as in osmo_fr_check_sid() in gsm610. […]

    Done

  • Patch Set #1, Line 293: for (i = 0; i < ARRAY_SIZE(sid_code_word_bits); i++)

    Once again I was copying the code structure and style from osmo_fr_check_sid() and osmo_hr_check_sid […]

    Done

To view, visit change 32034. To unsubscribe, or for help writing mail filters, visit settings.