Attention is currently required from: laforge, lynxis lazus.
2 comments:
Patchset:
I'm not following here.
1- You are adding a default value which is basically rand()%256, which defeats the purpose of restart_counter.
2- AFAIU you can configure the restart_counter from config file, but then that means everytime osmo-epdg restarts a user needs to manually edit the file and start osmo-epdg again?
I don't see how is this improving the situation over last commit, actually it's worse afaiu.
File src/epdg_gtpc_s2b.erl:
Patch Set #5, Line 111: % Use system_time in order to ensure a fresh system wouldn't re-use always the same restart_counter
AFAIU this is not true, you have 1/256 chance to get the same restart_counter every time you start osmo-epdg.
To view, visit change 41588. To unsubscribe, or for help writing mail filters, visit settings.