laforge submitted this change.

View Change


Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified jolly: Looks good to me, but someone else must approve laforge: Looks good to me, approved
gsm: fix osmo_mobile_identity_decode(): init *mi on error

Change-Id: I1c1503120c6c0e5479d8350fe762470bdb6266b8
---
M src/gsm/gsm48.c
1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index 4f79026..64b1765 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -641,8 +641,10 @@
char *str = NULL; /* initialize to avoid uninitialized false warnings on some gcc versions (11.1.0) */
size_t str_size = 0; /* initialize to avoid uninitialized false warnings on some gcc versions (11.1.0) */

- if (!mi_data || mi_len < 1)
- return -EBADMSG;
+ if (!mi_data || mi_len < 1) {
+ rc = -EBADMSG;
+ goto return_error;
+ }

nibbles_len = (mi_len - 1) * 2 + ((mi_data[0] & GSM_MI_ODD) ? 1 : 0);


To view, visit change 35504. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1c1503120c6c0e5479d8350fe762470bdb6266b8
Gerrit-Change-Number: 35504
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged