Attention is currently required from: osmith, pespin.

View Change

1 comment:

• File src/gprs/gprs_llc_parse.c:

  • Patch Set #1, Line 138: ghp->data = (uint8_t *)&ctrl[3];

    You are also telling the user that calling the function won't make any kind of modification at any time to contents of that address at any time.

    Not at any time, but only during the function exec time.

    What if the user passes a const pointer coming from a write-protected memory region?

    Then it's still responsibility of the user to not modify a write-protected memory region. There exist functions in glibc internally casting const to non-const, e.g. memchr(), strchr(), or strstr(). Do you also consider them wrong?

To view, visit change 29279. To unsubscribe, or for help writing mail filters, visit settings.