Attention is currently required from: dexter.

View Change

3 comments:

• File library/PCUIF_CodecPort.ttcn:

  • Patch Set #2, Line 217: pt.send(t_SD_PCUIF(conn_id, ts_PCUIF_DATA_REQ(bts_nr, 0, 0, 0, 0, PCU_IF_SAPI_AGCH_2, enc_PCUIF_agch(agch))));

    shouldn't tbis be enc_PCUIF_agch2?

  • Patch Set #2, Line 220: /* Exit early when the caller is not interested in the confirmation message */

    I think you are mixing 2 things her: confirmation and wait_for_confirmation. The fact that you want a confirmation is orthogonal to the fact of willing to wait for it.

• File library/PCUIF_Types.ttcn:

  • Patch Set #2, Line 326: * data request (data_req) under SAPI PCU_IF_SAPI_AGCH_2. */

    I wonder how do we properly enc/dec PCH and AGCH <v11 in here, since the records seem to apply to v11 only?

To view, visit change 34066. To unsubscribe, or for help writing mail filters, visit settings.